ref: aktualizr client + secondary interface #1719

kbushgit · 2020-07-09T15:30:35Z

Signed-off-by: Kostiantyn Bushko kostiantyn.bushko@yahoo.com

pattivacek

Looks pretty good.

include/libaktualizr/aktualizr.h

pattivacek · 2020-07-13T08:16:16Z

src/libaktualizr/primary/aktualizr.cc

 #include <sodium.h>
+#include <chrono>


Not a big deal, but C++ headers should be listed before external libs.

It's not my fault, make format makes this changed(:

Even if you put empty lines between the C++ and external header sections?

thanks it works

pattivacek · 2020-07-13T08:17:00Z

docs/ota-client-guide/modules/ROOT/pages/libaktualizr-getstarted.adoc


-To use the API, add the `src/libaktualizr` directory to your include path and add `# include "primary/aktualizr.h"` to your source file.
+To use the API, add the `aktualizr/include` directory to your include path and add `# include <libaktualizr/aktualizr.h>` to your source file.


Not your change, but why is there a space between the # and include?

pattivacek · 2020-07-15T09:25:22Z

I'm not so sure about putting some headers in a secondary subdirectory of the include/libaktualizr directory. Those headers are still specifically for the Primary to use, so to me it seems like a confusing separation. Or was there a specific goal you were trying to achieve with that?

kbushgit · 2020-07-16T09:24:01Z

I'm not so sure about putting some headers in a secondary subdirectory of the include/libaktualizr directory. Those headers are still specifically for the Primary to use, so to me it seems like a confusing separation. Or was there a specific goal you were trying to achieve with that?

No, there is no specific purpose, I'm just not sure if we have to mimic the structure of folders in the public headers as it is in the src?
Is the idea, to put all those headers in one folder more comfortable for you?

codecov-commenter · 2020-07-23T10:30:46Z

Codecov Report

Merging #1719 into master will decrease coverage by 3.44%.
The diff coverage is 56.75%.

@@            Coverage Diff             @@
##           master    #1719      +/-   ##
==========================================
- Coverage   74.82%   71.37%   -3.45%     
==========================================
  Files         186      186              
  Lines       13723    14381     +658     
==========================================
- Hits        10268    10265       -3     
- Misses       3455     4116     +661

Impacted Files	Coverage Δ
include/libaktualizr/aktualizr.h	`100.00% <ø> (ø)`
include/libaktualizr/secondary_provider.h	`100.00% <ø> (ø)`
src/aktualizr_info/main.cc	`70.83% <ø> (-22.36%)`	⬇️
src/aktualizr_primary/main.cc	`65.97% <ø> (ø)`
src/aktualizr_primary/secondary_config.cc	`63.76% <ø> (-24.24%)`	⬇️
src/libaktualizr-isotp/isotpsecondary.cc	`0.00% <ø> (ø)`
src/libaktualizr-isotp/isotpsecondary.h	`0.00% <ø> (ø)`
src/libaktualizr-posix/ipuptanesecondary.h	`81.81% <ø> (ø)`
src/libaktualizr/package_manager/debianmanager.cc	`69.04% <0.00%> (-5.32%)`	⬇️
src/libaktualizr/package_manager/debianmanager.h	`60.00% <ø> (ø)`
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c861b0...2656eae. Read the comment docs.

Signed-off-by: Kostiantyn Bushko <kostiantyn.bushko@yahoo.com>

Signed-off-by: Kostiantyn Bushko <kbushko@intellias.com>

pattivacek · 2020-07-27T14:43:00Z

src/virtual_secondary/partialverificationsecondary.cc

@@ -37,14 +37,15 @@ data::InstallationResult PartialVerificationSecondary::putMetadata(const Target
  }

  // TODO(OTA-2484): check for expiration and version downgrade
-  root_ = Uptane::Root(RepositoryType::Director(), Utils::parseJSON(director_root), root_);
+  Uptane::Root root(Root::Policy::kAcceptAll);
+  root = Uptane::Root(RepositoryType::Director(), Utils::parseJSON(director_root), root);


This is a downgrade in functionality by not storing the Root to check it the next time around. However, this whole class is woefully incomplete, so it doesn't really matter. It needs a lot of work and that isn't part of the scope here.

pattivacek reviewed Jul 13, 2020

View reviewed changes

kbushgit force-pushed the ref/libaktualizr/aktualizr-client branch from 9522dea to 0614de1 Compare July 14, 2020 09:19

kbushgit force-pushed the ref/libaktualizr/aktualizr-client branch from 764c225 to 3a3c924 Compare July 21, 2020 10:35

Kostiantyn Bushko and others added 12 commits July 23, 2020 17:35

ref: aktualizr client + secondary interface

565972c

Signed-off-by: Kostiantyn Bushko <kostiantyn.bushko@yahoo.com>

ref intermediate step: move secondary provider def

84bc60e

Signed-off-by: Kostiantyn Bushko <kostiantyn.bushko@yahoo.com>

remove forward declaration for SecondaryInfo class

4b78ebe

Signed-off-by: Kostiantyn Bushko <kostiantyn.bushko@yahoo.com>

fix doxygen

c02a7d1

Signed-off-by: Kostiantyn Bushko <kostiantyn.bushko@yahoo.com>

remove folder for headers related to secondary API

00f8ca8

Signed-off-by: Kostiantyn Bushko <kbushko@intellias.com>

ref: move package manager interface to public API

77aba6f

Signed-off-by: Kostiantyn Bushko <kbushko@intellias.com>

ref: secondaries impl, reduce dependencies from private API

feec1ab

Signed-off-by: Kostiantyn Bushko <kbushko@intellias.com>

added missed headers in package manager implementations

a5ce660

Signed-off-by: Kostiantyn Bushko <kbushko@intellias.com>

fix formating

b1e3f87

Signed-off-by: Kostiantyn Bushko <kbushko@intellias.com>

aktualizr: fix the clang-tidy error regarding trivial dtor

fb0c69c

Signed-off-by: Kostiantyn Bushko <kbushko@intellias.com>

fix clang-tidy issue with default dtor and forward declaration

e8faad4

Signed-off-by: Kostiantyn Bushko <kbushko@intellias.com>

merging: builder for secondary provider

2656eae

Signed-off-by: Kostiantyn Bushko <kbushko@intellias.com>

kbushgit force-pushed the ref/libaktualizr/aktualizr-client branch from 82be3de to 2656eae Compare July 23, 2020 15:42

pattivacek approved these changes Jul 27, 2020

View reviewed changes

pattivacek merged commit 7257723 into master Jul 27, 2020

pattivacek deleted the ref/libaktualizr/aktualizr-client branch July 27, 2020 14:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ref: aktualizr client + secondary interface #1719

ref: aktualizr client + secondary interface #1719

kbushgit commented Jul 9, 2020

pattivacek left a comment

pattivacek Jul 13, 2020

kbushgit Jul 14, 2020

pattivacek Jul 14, 2020

kbushgit Jul 14, 2020

pattivacek Jul 13, 2020

pattivacek commented Jul 15, 2020

kbushgit commented Jul 16, 2020

codecov-commenter commented Jul 23, 2020 •

edited

Loading

pattivacek Jul 27, 2020


		To use the API, add the `src/libaktualizr` directory to your include path and add `# include "primary/aktualizr.h"` to your source file.
		To use the API, add the `aktualizr/include` directory to your include path and add `# include <libaktualizr/aktualizr.h>` to your source file.

ref: aktualizr client + secondary interface #1719

ref: aktualizr client + secondary interface #1719

Conversation

kbushgit commented Jul 9, 2020

pattivacek left a comment

Choose a reason for hiding this comment

pattivacek Jul 13, 2020

Choose a reason for hiding this comment

kbushgit Jul 14, 2020

Choose a reason for hiding this comment

pattivacek Jul 14, 2020

Choose a reason for hiding this comment

kbushgit Jul 14, 2020

Choose a reason for hiding this comment

pattivacek Jul 13, 2020

Choose a reason for hiding this comment

pattivacek commented Jul 15, 2020

kbushgit commented Jul 16, 2020

codecov-commenter commented Jul 23, 2020 • edited Loading

Codecov Report

pattivacek Jul 27, 2020

Choose a reason for hiding this comment

codecov-commenter commented Jul 23, 2020 •

edited

Loading