Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Remove obsolete code #1732

Merged
merged 4 commits into from
Aug 3, 2020
Merged

Remove obsolete code #1732

merged 4 commits into from
Aug 3, 2020

Conversation

pattivacek
Copy link
Collaborator

Just cleaning up cruft.

It was never finished and never really clear what it was intended for.
It was also subtly (and unsubtly) broken in many ways.

Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
It was incomplete, untested, and practically unmaintained.

Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
It was unused, poorly tested, poorly maintained, and only used by
libuptiny, which also hasn't been touched or tested in ages.

Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
They were moved out of this repo long ago.

Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1732 into master will increase coverage by 21.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1732       +/-   ##
===========================================
+ Coverage   53.13%   74.26%   +21.13%     
===========================================
  Files         186      179        -7     
  Lines       14206    13801      -405     
===========================================
+ Hits         7548    10249     +2701     
+ Misses       6658     3552     -3106     
Impacted Files Coverage Δ
include/libaktualizr/config.h 66.66% <ø> (+66.66%) ⬆️
include/libaktualizr/types.h 66.46% <ø> (+66.46%) ⬆️
src/libaktualizr/crypto/keymanager.cc 58.02% <100.00%> (-29.74%) ⬇️
src/libaktualizr/primary/sotauptaneclient.cc 92.84% <100.00%> (ø)
src/virtual_secondary/virtualsecondary.cc 93.65% <0.00%> (+14.98%) ⬆️
src/libaktualizr/crypto/crypto.cc 84.10% <0.00%> (+22.75%) ⬆️
src/libaktualizr/package_manager/ostreemanager.cc 79.92% <0.00%> (+29.11%) ⬆️
src/libaktualizr/crypto/crypto.h 57.89% <0.00%> (+31.70%) ⬆️
src/libaktualizr/primary/initializer.h 86.66% <0.00%> (+34.66%) ⬆️
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ead1c...7d11e90. Read the comment docs.

@pattivacek pattivacek merged commit 388c7ba into master Aug 3, 2020
@pattivacek pattivacek deleted the feat/rm-obsolete-code branch August 3, 2020 07:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants