This repository has been archived by the owner on May 21, 2024. It is now read-only.
OTA-4864 - improve binary file download progress logging #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad proggress each 15 sec Signed-off-by: aodukha <aodukha@gmail.com>
Signed-off-by: aodukha <aodukha@gmail.com>
aodukha
force-pushed
the
feat/ota-4864/improve-binary-file-download-progress-logging
branch
from
8b5b615
to
2faa877
Compare
Codecov Report
@@ Coverage Diff @@
## master #1756 +/- ##
==========================================
- Coverage 81.98% 75.88% -6.11%
==========================================
Files 178 178
Lines 12481 13513 +1032
==========================================
+ Hits 10233 10254 +21
- Misses 2248 3259 +1011
Continue to review full report at Codecov.
|
pattivacek
reviewed
Sep 8, 2020
| @@ -98,6 +112,7 @@ bool PackageManagerInterface::fetchTarget(const Uptane::Target& target, Uptane:: | |||
| return true; | |||
| } | |||
| std::unique_ptr<DownloadMetaStruct> ds = std_::make_unique<DownloadMetaStruct>(target, progress_cb, token); | |||
| ds->time_start = ds->time_lastreport = std::chrono::steady_clock::now(); //use this time to report download progress it download take long time | |||
There was a problem hiding this comment.
Is time_start used for anything? Seems unnecessary.
There was a problem hiding this comment.
removed. it was artifact from older and a bit more complicated version
Signed-off-by: aodukha <aodukha@gmail.com>
Signed-off-by: aodukha <aodukha@gmail.com>
pattivacek
reviewed
Sep 8, 2020
Signed-off-by: aodukha <aodukha@gmail.com>
pattivacek
approved these changes
Sep 9, 2020
pattivacek
deleted the
feat/ota-4864/improve-binary-file-download-progress-logging
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log into output download progress each 15sec for big binary files