Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

fetcher: urlencode target names #996

Merged
merged 2 commits into from
Nov 9, 2018
Merged

fetcher: urlencode target names #996

merged 2 commits into from
Nov 9, 2018

Conversation

OYTIS
Copy link
Contributor

@OYTIS OYTIS commented Nov 8, 2018

Signed-off-by: Anton Gerasimov anton.gerasimov@here.com

Needed for Sachertorte, but a good thing to have in general probably.

Copy link
Contributor

@lbonn lbonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool! Could have some basic test cases.

@pattivacek
Copy link
Collaborator

+1 for tests.

Signed-off-by: Anton Gerasimov <anton.gerasimov@here.com>
@codecov-io
Copy link

codecov-io commented Nov 8, 2018

Codecov Report

Merging #996 into master will increase coverage by 0.01%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #996      +/-   ##
==========================================
+ Coverage   82.94%   82.96%   +0.01%     
==========================================
  Files         187      187              
  Lines       13006    13019      +13     
==========================================
+ Hits        10788    10801      +13     
  Misses       2218     2218
Impacted Files Coverage Δ
src/libaktualizr/utilities/utils.h 90.47% <ø> (ø) ⬆️
src/libaktualizr/uptane/fetcher.cc 91.91% <100%> (ø) ⬆️
src/libaktualizr/utilities/utils_test.cc 99.08% <100%> (ø) ⬆️
src/libaktualizr/utilities/utils.cc 86.08% <92.3%> (+0.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4621a15...83c163f. Read the comment docs.

Signed-off-by: Anton Gerasimov <anton.gerasimov@here.com>
@OYTIS OYTIS merged commit c4f14cf into master Nov 9, 2018
@pattivacek pattivacek deleted the urlencode branch November 9, 2018 09:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants