Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: Expose the device registry network endpoint #69

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion templates/services/gateway.tmpl.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
data:
gateway.conf: |-
server {
error_log /var/log/nginx/error.log debug;
error_log /var/log/nginx/error.log info;
listen 8443 ssl;
server_name ota.ce;
ssl_certificate /etc/ssl/gateway/server.chain.pem;
Expand Down Expand Up @@ -52,6 +52,11 @@ data:
proxy_set_header x-ats-namespace $deviceNamespace;
proxy_pass http://device-registry;
}
location /system_info/network {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can rewrite all /system_info/ endpoints to device-registry. Aktualizr can access these instead of the legacy /core/system_info.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that would be great. I'd tried to get some traction on that method with aktualizr:

advancedtelematic/aktualizr#716

but haven't heard anything. Shall we table this and wait on a change in that project first?

rewrite ^/system_info/(.*)$ /api/v1/devices/$deviceUuid/system_info/network break;
proxy_set_header x-ats-namespace $deviceNamespace;
proxy_pass http://device-registry;
}
}
upstreams.conf: |-
upstream treehub {
Expand Down