Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary Navigation Menu - issue with subitems #634

Open
daniel-eesti opened this issue Feb 20, 2023 · 6 comments
Open

Primary Navigation Menu - issue with subitems #634

daniel-eesti opened this issue Feb 20, 2023 · 6 comments
Labels
ALPS v.3 Tickets for the ALPS v.3 development enhancement

Comments

@daniel-eesti
Copy link

Forth-level subtitles in Primary Navigation Menu aren't displayed.

Video Description: https://www.dropbox.com/s/egrynyy8m7taxyl/Primary%20Navigation%20Menu%20-%20issue%20with%20subitems.mp4?dl=0

@YauheniKapliarchuk
Copy link
Collaborator

Hi @daniel-eesti

I did some investigation and found some strange behavior on our theme.
We need update our styles and js files for this functionality.

I moved this ticket "On Hold" column, because this is not critical for current release.

Thanks,
Best Regards!

@YauheniKapliarchuk YauheniKapliarchuk added the ALPS v.3 Tickets for the ALPS v.3 development label Mar 7, 2023
@YauheniKapliarchuk
Copy link
Collaborator

PR with some changes.

Thanks,
Best Regards!

@johnrbeckett
Copy link
Contributor

This is a feature request that needs review.

@YauheniKapliarchuk
Copy link
Collaborator

YauheniKapliarchuk commented May 8, 2023

Hi @johnrbeckett,
Sorry, I miss the link to this PR. This is here - #643.

I added one level for getting this functionality. But this is fixed levels count on the UI part.

Thanks,
Best Regards!

@YauheniKapliarchuk
Copy link
Collaborator

Hi @daniel,

Could you please provide markup for this menu structure?

Thanks,
Best Regards!

@YauheniKapliarchuk
Copy link
Collaborator

YauheniKapliarchuk commented Dec 12, 2023

Hi,

Design you can see here - https://www.figma.com/file/edkYtLw5YCYIlFpudaQ4WS/ALPS?type=design&node-id=145%3A2&mode=design&t=zligS2BJgST4p3kz-1

Focus - focus underline same color as text.

Thanks,
Best Regards!

!Note:
adventist.org has to be on prod instead of the child theme for this new feature to work.

@johnrbeckett
@daniel-eesti - has to review before release

YauheniKapliarchuk added a commit that referenced this issue Mar 26, 2024
…menu-add-new-level

#634 primary navigation menu add new level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALPS v.3 Tickets for the ALPS v.3 development enhancement
Projects
None yet
Development

No branches or pull requests

3 participants