Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF: Split CSS by color theme #463

Closed
designerbrent opened this issue Jun 17, 2020 · 2 comments
Closed

PERF: Split CSS by color theme #463

designerbrent opened this issue Jun 17, 2020 · 2 comments

Comments

@designerbrent
Copy link
Collaborator

In reviewing Google Chrome's coverage reports, I've noted that on a given page, over 90% of the CSS is not used. I realize this is one page, but I also know that with 16 color themes, we are pushing WAY more code then we need to push on each page load.

What would it take to refactor the CSS so we could render 17 options for the main.css file, one unified file (like we have now) and one for each color theme, for example main-treefrog.css?

This would allow a refactoring of inclusion code in the Wordpress and other CMS themes to only include the CSS needed for each theme.

Thoughts? @davideleuterius @kelscahill @eduludi @sergsadovyi

@designerbrent
Copy link
Collaborator Author

@sergsadovyi Can you take a look at this issue as at the same time as #457? I think this means the version.json file will be expanded to include the URL for each version of the CSS.

designerbrent added a commit that referenced this issue Jul 2, 2020
@designerbrent
Copy link
Collaborator Author

This has now been implemented starting in version 3.6.3 and can be seen in the versions.json file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants