Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the Search Patterns #513

Closed
designerbrent opened this issue Oct 8, 2020 · 4 comments · Fixed by #519
Closed

Update to the Search Patterns #513

designerbrent opened this issue Oct 8, 2020 · 4 comments · Fixed by #519
Assignees

Comments

@designerbrent
Copy link
Collaborator

@designerbrent commented on Thu Sep 17 2020

We need to make some revisions to the search patterns

The patterns below are what these should be updated to:

Sketch Template

Search Header with Suggestions

Mobile

Search Page Patterns 375

Desktop

Search Page Patterns 1440

Search Drawer with Suggestions

Mobile

Search Drawer 375

Desktop

Search Drawer 1440

Search Page Template

Mobile

Search Page 375

Desktop

Search Page 1440

@davideleuterius
Copy link
Contributor

@designerbrent - I am reviewing this now. I don't see a current implementation of the "this site / other sites" functionality so I am assuming this is new to this as well? Or do you have something in place that we can pull on to generate these different groups of links?

@designerbrent
Copy link
Collaborator Author

@davideleuterius "this site / other site" functionality is not used yet.

@davideleuterius
Copy link
Contributor

@designerbrent - one further question as I am working on this now. The bottom part of the search drawer, where the drawer menu is located, seems to be styled differently than how it currently is. Was this part of the changes with this or is that to be ignored in implementing this? Thanks!

@designerbrent
Copy link
Collaborator Author

From what I see, it looks basically the same. The only change should be in the upper part of the menu that displays the search results. The lower part is just pushed down to make room for the results.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants