-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontpage Patterns #524
Comments
here is the GTMetrix report: https://gtmetrix.com/reports/www.adventist.org/DozdGtFt/ |
Here is a similar report for the ALPS Page: https://gtmetrix.com/reports/alps.adventist.io/7wFcfh2L/ (I don't expect this one to be amazing, as I know many things are getting pulled that aren't optimized, however the CLS is still showing on the |
@designerbrent After looking into increasing performance, I made a few updates in ALPS PL, as well as the AORG child theme. See the PR's below. Also, based on the GTMetrix report a performance plugin will dramatically increase that score. With a performance plugin you can defer JS and Lazy Load Images. One that we use at Southleft is Perfmatters. You can check out the features here: https://perfmatters.io/features/ |
Thanks for making these adjustments, @kelscahill. Those are great changes and I'll merge them tomorrow, hopefully. One other thought: How much would it save on the main ALPS library to split out the front page styles into its own file that would get loaded just on those pages? As for performance plugins, yes, I do run WP Rocket and that does help a lot. I haven't used PerfMatters but it looks similar to WP Rocket. |
@kelscahill Have you had a chance to look at the |
@designerbrent I reran the GMetrix test and looks like the site has an A now! Since the score is so high, I don't see much value in separating the homepage css, but if we ever had to this website might be of value: https://unused-css.com/ The |
I'm happy to see the Let's address the |
@kelscahill After further testing by disabling Javascript, I found that the flash of gradient that is causing problems is the gradient that shows comes from the gradient classes ( In looking in to this more, I found that the class on the pattern of I've fixed it in the Adventist.org theme and will get the fixes applied to the other projects soon. |
@joslemmons See Brent's comments above. |
@kelscahill and @joslemmons I'm going to close this ticket now, as I think we have addressed the issues at hand, either through the changes that happened here or via server improvements. |
As we have worked to further refine the homepage of Adventist.org and optimize it for WebVitals, we are finding some challenges with the patterns introduced in this PR #425
The text was updated successfully, but these errors were encountered: