Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3.additional homepage #425

Merged
merged 14 commits into from
Dec 4, 2019
Merged

V3.additional homepage #425

merged 14 commits into from
Dec 4, 2019

Conversation

kelscahill
Copy link
Collaborator

@designerbrent The development for the unique ALPS homepage is created in PL. Please review the new PL template ALPS Home and let me know if you have any changes. You'll be able to update all the content in PL, then we'll just copy the html over to a php file for wordpress. I did have to make changes to Wordpress to accommodate for the new header. The PR is started here: adventistchurch/alps-wordpress#401 Once ALPS PL is merged, then we can test the Wordpress instance. Please let me know if this makes sense!

Copy link
Collaborator

@designerbrent designerbrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some issues related to the icons in menus:

Menu Drawer

The menu drawer has icons that are above the menu items.
2019-12-02 at 3 42 PM

Secondary navigation

All the icons are missing here:
2019-12-02 at 3 44 PM

Tertiary menu

The arrow icon is also missing here.
2019-12-02 at 3 48 PM

@designerbrent
Copy link
Collaborator

Also, between 900px and 1290px the images aren't sized correctly to display the full height of the box.
2019-12-02 at 3 51 PM

@kelscahill
Copy link
Collaborator Author

@designerbrent Those issues are now fixed.

designerbrent
designerbrent previously approved these changes Dec 4, 2019
@designerbrent designerbrent merged commit f64189e into v3.x Dec 4, 2019
@designerbrent designerbrent mentioned this pull request Feb 17, 2021
designerbrent added a commit that referenced this pull request Mar 17, 2021
#425: Resized background image for performance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants