Summary
The way the proxy protocol listener is implemented in sshpiper can allow an attacker to forge their connecting address.
Details
This commit added the proxy protocol listener as the only listener in sshpiper, with no option to toggle this functionality off. This means that any connection that sshpiper is directly (or in some cases indirectly) exposed to can use proxy protocol to forge its source address.
PoC
You can use a configuration like this in HAProxy:
listen w-send-proxy
mode tcp
log global
option tcplog
bind *:27654
tcp-request connection set-src ipv4(1.1.1.1)
server app1 ssh-piper-hostname:22 send-proxy
When connecting through HAProxy, sshpiper will log connections as originating from 1.1.1.1. The proxy protocol data is designed to survive multiple load balancers or proxies and pass through to sshpiper at the end, so it should only be enabled trusted environments. This should be behind a configuration option or startup flag to prevent abuse when public connections can be made to sshpiper.
This is also backed up by the specification for proxy protocol:
The receiver MUST be configured to only receive the protocol described in this
specification and MUST not try to guess whether the protocol header is present
or not. This means that the protocol explicitly prevents port sharing between
public and private access. Otherwise it would open a major security breach by
allowing untrusted parties to spoof their connection addresses. The receiver
SHOULD ensure proper access filtering so that only trusted proxies are allowed
to use this protocol.
Impact
Any users of sshpiper who need logs from it for whitelisting/rate limiting/security investigations could have them become much less useful if an attacker is sending a spoofed source address.
References
pgibson1-godaddy Reporter
mtrop-godaddy Analyst
Summary
The way the proxy protocol listener is implemented in sshpiper can allow an attacker to forge their connecting address.
Details
This commit added the proxy protocol listener as the only listener in sshpiper, with no option to toggle this functionality off. This means that any connection that sshpiper is directly (or in some cases indirectly) exposed to can use proxy protocol to forge its source address.
PoC
You can use a configuration like this in HAProxy:
When connecting through HAProxy, sshpiper will log connections as originating from
1.1.1.1. The proxy protocol data is designed to survive multiple load balancers or proxies and pass through to sshpiper at the end, so it should only be enabled trusted environments. This should be behind a configuration option or startup flag to prevent abuse when public connections can be made to sshpiper.This is also backed up by the specification for proxy protocol:
Impact
Any users of sshpiper who need logs from it for whitelisting/rate limiting/security investigations could have them become much less useful if an attacker is sending a spoofed source address.
References