Skip to content

matrix-media-repo: Unsafe media served inline on download endpoints

Moderate severity GitHub Reviewed Published Sep 8, 2023 in t2bot/matrix-media-repo • Updated Nov 10, 2023

Package

gomod github.com/turt2live/matrix-media-repo (Go)

Affected versions

< 1.3.0

Patched versions

1.3.0

Description

Impact

A malicious user can upload an SVG image containing JavaScript to their server. When matrix-media-repo is asked to serve that media via the /_matrix/media/(r0|v3)/download endpoint, it would be served with a Content-Disposition of inline. This can allow JavaScript to run in the browser if a client links to the /download endpoint directly.

Server operators which do not share a domain between matrix-media-repo and other services are not affected, but are encouraged to upgrade regardless.

Patches

t2bot/matrix-media-repo@77ec235 and t2bot/matrix-media-repo@bf8abdd fix the issue. Operators should upgrade to v1.3.0 as soon as possible.

Workarounds

The Content-Disposition header can be overridden by the reverse proxy in front of matrix-media-repo to always use attachment, defeating this issue at the cost of "worse" user experience when clicking download links.

References

https://developer.mozilla.org/en-US/docs/Web/SVG/Element/script

References

@turt2live turt2live published to t2bot/matrix-media-repo Sep 8, 2023
Published to the GitHub Advisory Database Sep 8, 2023
Reviewed Sep 8, 2023
Published by the National Vulnerability Database Sep 8, 2023
Last updated Nov 10, 2023

Severity

Moderate

CVSS overall score

This score calculates overall vulnerability severity from 0 to 10 and is based on the Common Vulnerability Scoring System (CVSS).
/ 10

CVSS v3 base metrics

Attack vector
Network
Attack complexity
Low
Privileges required
Low
User interaction
Required
Scope
Changed
Confidentiality
Low
Integrity
None
Availability
None

CVSS v3 base metrics

Attack vector: More severe the more the remote (logically and physically) an attacker can be in order to exploit the vulnerability.
Attack complexity: More severe for the least complex attacks.
Privileges required: More severe if no privileges are required.
User interaction: More severe when no user interaction is required.
Scope: More severe when a scope change occurs, e.g. one vulnerable component impacts resources in components beyond its security scope.
Confidentiality: More severe when loss of data confidentiality is highest, measuring the level of data access available to an unauthorized user.
Integrity: More severe when loss of data integrity is the highest, measuring the consequence of data modification possible by an unauthorized user.
Availability: More severe when the loss of impacted component availability is highest.
CVSS:3.1/AV:N/AC:L/PR:L/UI:R/S:C/C:L/I:N/A:N

EPSS score

0.079%
(35th percentile)

Weaknesses

CVE ID

CVE-2023-41318

GHSA ID

GHSA-5crw-6j7v-xc72

Source code

Credits

Loading Checking history
See something to contribute? Suggest improvements for this vulnerability.