Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates #2

Merged
merged 59 commits into from
Apr 19, 2024
Merged

Updates #2

merged 59 commits into from
Apr 19, 2024

Conversation

AndrewQuijano
Copy link
Collaborator

  • Add subtract from ciphertext for easy usage of y - [x]
  • Fixed Joye and Salehi comparison
  • Automate work on creating JAR file releases
  • Use Log4J logging instead of printing to standard out

@AndrewQuijano
Made the switch to using Log4J to log
10158a6
@AndrewQuijano
Removing print to stdout, just find it under logs/application.log. I …
d3203ae 
…will probably make an Alice debug version sometime? In the meantime I need to fix Joye comparison
@AndrewQuijano
Cleaned up how I am logging the name of alice/bob under testing, but …
3f4ff26 
…gradlew works. Not sure why it isnt consistent on passing
@AndrewQuijano
logging last stack trace
e453e99
@AndrewQuijano
OK, I can confirm I have the Joye and Salehi protocol working as inte…
c05e455 
…nded, phew had a scare. But I did clean up log message of protocol 1 in general.
@AndrewQuijano
Joye and Salehi works! More importantly, it is ALWAYS consistent even…
e1951e2 
… using DGK ciphertext about getting X >= Y compared to Veugen! Nice!
@AndrewQuijano
So fixed typo on name for 40, and based on alans feedback I added sub…
809a239 
…tract ciphertext
@AndrewQuijano
Going to poke around about releasing JAR file
eaa3ca1
@AndrewQuijano AndrewQuijano self-assigned this Mar 17, 2024
AndrewQuijano and others added 15 commits March 22, 2024 15:56
@AndrewQuijano
Update action versions
35b82c1
@AndrewQuijano
Update to avoid using set-output as that is EOL
b3f4e22
@AndrewQuijano
Trying to fix how tag is made
b926906
@AndrewQuijano
maybe needed curly brace?
4c63b0c
@AndrewQuijano
going to copy Panda
308f383
@AndrewQuijano
Fix release
2d3d2e5
@AndrewQuijano
Want this to be Version 1
d87ce5a
@AndrewQuijano
Revive testing, I think I got the whole versioning working, I think w…
858a401 
…ould be nice to have 1.0 match what I got after my REU, and 2.0 match all the work I did for Level-Site PPDT/VICOR
@AndrewQuijano
I need to make sure I ONLY create the release if the tests pass on ma…
1ebf663 
…in too
@AndrewQuijano
Using serial tag.
bf8d3e7
@AndrewQuijano
Standardize how alice will always get the XOR
b150821
@AndrewQuijano
Fix XOR, timing attack if bits not equal is fixed now
8260471
@AndrewQuijano
For lots of other XOR operations I also had to modify the index
9c9bcdd
@AndrewQuijano
do not make version until test passes
e5e31bd
OK, so I broke a lot more than I realized, but basic alice seems to w…
f959cf7 
…ork, I will slowly work on getting this to work
Andrew Quijano and others added 29 commits April 2, 2024 16:54
Joye is alive and DO NOT mess with the bit function
d2258f8
Revived Veugen, will create branch to fix the timing attack on unequa…
26a58e7 
…l bits
@AndrewQuijano
How tf did I not notice the code duplication I deleted in Modified Pr…
cf61cb8 
…otocol3 for Bob? Whatever, fixed now, but with this, that should mean if I fix just alice/bob, I get every other version for free
@AndrewQuijano
I noticed encrypted_equals check works just fine somehow without need…
c211e0b 
…ing early exit, need to poke if this means my encrypted_xor works for x < y and x > y. Also, figure should be consistent on for loop logic to use xor array length
@AndrewQuijano
Make sure Alice_joye entirely uses xor length
817cc88
@AndrewQuijano
Apply XOR logic to Protocol 3, I am not brave enough to try it on Mod…
2d250a0 
…ified Protocol 3
@AndrewQuijano
Decided to be brave and update for all to use XOR length
dfd09d5
@AndrewQuijano
I still want to know why encrypted_equals does NOT need the bit size …
c47d791 
…check
@AndrewQuijano
The private equality check somehow ensured x and y had same number of…
c713eef 
… bits, hence it always worked. Next step, check the encrypted XOR method
@AndrewQuijano
Timing attack fix applied to original alice. Will try fixing Joye next
854aeeb
@AndrewQuijano
Joye and Salehi is fixed too for XOR
353d4e6
@AndrewQuijano
bit alreday does padding
2b22413
@AndrewQuijano
Modified Protocol3 is corrected. Fixing Protocol 3 next
c157686
@AndrewQuijano
Merge pull request #1 from AndrewQuijano/timing
7daca58 
Fix timing attack
@AndrewQuijano
Should leverage warn
323765c
@AndrewQuijano
I will allow encrypted negative, but warn users in logger
c53279d
@AndrewQuijano
Update test concat, seems XOR works well even with bigger integer des…
a6e102b 
…parity, but I need to drill deeper within comparison protocol 1
@AndrewQuijano
Refactoring to allow for integration testing directly
353cea0
@AndrewQuijano
Edge case if both x and y is 0 bits long so XOR is 0 bits long
6977161
@AndrewQuijano
Got a unit test thing to help debug Joye, still turning out to be har…
3fe76dc 
…d to replicate
@AndrewQuijano
more linting fixes
e42b4e4
@AndrewQuijano
Interesting, seems like I need to change how I use hamming weight now…
e13e210 
… because I need to know t-bits for both x and y.
@AndrewQuijano
Updating rest of testing code. Going to re-run this test a few more t…
31da1f5 
…imes, I hope I finally killed this lasy bug on Joye and Salehi
@AndrewQuijano
Seems like the issue was getting stuck about readObject, think I got …
4f4a44b 
…the fix
@AndrewQuijano
BRUH, really, I missed THAT it should NOT be x? UGH. But, now this sh…
ef884a0 
…ould be bug free
@AndrewQuijano
Reduce logging level
8861696
@AndrewQuijano
Want exception to be thrown if an assert fails
e9b5e7f
@AndrewQuijano
I want to debug why PPDT still seems to act up, confirm Protocol 1 is…
a89bc37 
… truly fixed by getting the inputs that might be causing crashes
@AndrewQuijano
Add timing attack protections
a4e6dfb
@AndrewQuijano AndrewQuijano merged commit 67d18a3 into adwise-fiu:main Apr 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogbautista ogbautista Awaiting requested review from ogbautista

Assignees

@AndrewQuijano AndrewQuijano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AndrewQuijano