Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move project menu to the "add layer" menu #10

Merged
merged 1 commit into from
Feb 12, 2019
Merged

move project menu to the "add layer" menu #10

merged 1 commit into from
Feb 12, 2019

Conversation

Gustry
Copy link
Contributor

@Gustry Gustry commented Jan 26, 2019

do not merge this one

I don't want to break the existing location of the menu bar.

What do you think about this location of the menu?
move_menu_to_layers

It makes more sense to me.
I'm fine of course to add an option in the settings about the location. Should we do this per project? Or a general project?

@xcaeag
Copy link
Collaborator

xcaeag commented Jan 28, 2019

Our users are used to the current location.
The change must remain optional, for all projects seems the best solution.
Thanks !

@xcaeag
Copy link
Collaborator

xcaeag commented Feb 12, 2019

I am working on the configuration, per project...
You were talking about SVG, what is it ? Then we can consider a v1.0 ?

@xcaeag xcaeag merged commit e9a2555 into aeag:master Feb 12, 2019
xcaeag added a commit that referenced this pull request Feb 12, 2019
@Gustry Gustry deleted the move_menu branch February 13, 2019 14:49
@Gustry
Copy link
Contributor Author

Gustry commented Feb 13, 2019

Thanks for merging. It was on my todolist for making the location setting.

You were talking about SVG, what is it ? Then we can consider a v1.0 ?

For now, I added the geometry icon.
I still would like to have custom SVG using this feature for instance qgis/QGIS#7433

@Gustry
Copy link
Contributor Author

Gustry commented Feb 13, 2019

But if you want to release the current plugin, it's fine for me. I think we made quite a few improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants