Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New loading before rendering #59

Merged
merged 4 commits into from
Nov 16, 2024
Merged

New loading before rendering #59

merged 4 commits into from
Nov 16, 2024

Conversation

Marc-Andrieu
Copy link
Contributor

Fix #47: see my comment there.

Content of this PR:

  • Putting the fallback of <SuspenseEmbed> to <></>: no annoying "Loading..." anymore.
  • Adding pure CSS skeletons that match perfectly ("at least on my machine") the shape of the <FormLabel> and <FormControl> of the <LoginCustomFormField>: this way, there's no more dependency and the size of the <CenteredCard> is preserved.
  • Version +2 because I forgot to update it in my previous PR.

We may want some refactoring later for the CSS and the <Suspense>-derived tags...

@Marc-Andrieu Marc-Andrieu added the help wanted Extra attention is needed label Sep 29, 2024
@Marc-Andrieu
Copy link
Contributor Author

How the skeletons render on my phone:

  • I artificially made them last a bit longer here for the video's sake.
  • If you zoom and use slow motion, it's imperceptibly taller with the skeletons.
Screen_Recording_20240930_212317_Ecosia.mp4

@Marc-Andrieu
Copy link
Contributor Author

Rendering on phone (see above for comparison): imperceptibly shorter this time

Screen_Recording_20241024_162909_Ecosia.mp4

@Marc-Andrieu Marc-Andrieu added enhancement New feature or request and removed help wanted Extra attention is needed release labels Oct 24, 2024
@armanddidierjean armanddidierjean merged commit b2a0e0a into main Nov 16, 2024
3 checks passed
@armanddidierjean armanddidierjean deleted the loading branch November 16, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "loading" texts
2 participants