refactor: virtua item type

pending on inokawa/virtua#550
aeharding · Nov 17, 2024 · d41fd8b · d41fd8b
1 parent 5993a0d
commit d41fd8b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 14 deletions.
diff --git a/src/features/comment/inTree/Comments.tsx b/src/features/comment/inTree/Comments.tsx
@@ -516,7 +516,6 @@ export default function Comments({
             }
             ref={virtuaRef}
             style={{ height: "100%" }}
-            // @ts-expect-error Virtua types not updated for forwardRef-less components
             item={IndexedVirtuaItem}
             overscan={1}
             onScroll={(offset) => {

diff --git a/src/helpers/virtua.tsx b/src/helpers/virtua.tsx
@@ -1,21 +1,11 @@
 import { CustomItemComponentProps } from "virtua";
 
-interface IndexedVirtuaItemProps extends CustomItemComponentProps {
-  ref: React.RefObject<HTMLDivElement>;
-}
-
 /**
  * Add data-index to each item for programmatic scrolling
  */
 export function IndexedVirtuaItem({
-  children,
   index,
-  style,
-  ref,
-}: IndexedVirtuaItemProps) {
-  return (
-    <div ref={ref} style={style} data-index={index}>
-      {children}
-    </div>
-  );
+  ...rest
+}: CustomItemComponentProps) {
+  return <div data-index={index} {...rest} />;
 }