Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Detailed score and age alerts #55

Merged
merged 7 commits into from
Jun 29, 2023

Conversation

httpjamesm
Copy link
Contributor

When clicking on your comment/post karma counts or account age number in Apollo's profile section, it opens up a popup with more detailed information. This PR adds similar functionality.

image
image
image

@aeharding
Copy link
Owner

Hi! Can you remove the prettier changes from this PR? Then it will be easier to review. Thanks very much!

@aeharding
Copy link
Owner

Thanks for clearing up the formatting!

  • Have you tried useIonAlert? That would probably reduce the amount of code quite a bit!
  • I totally didn't know this feature existed in Apollo. So thanks so much for this PR!

@httpjamesm
Copy link
Contributor Author

Unfortunately useIonAlert doesn't support multi-line messages, so I've instead separated it into a subheader and a message:

image

@aeharding
Copy link
Owner

I made a tweak to the PR to preserve newlines, and changed the showScoreAlert function.

I had to rebase due to conficts in index.css, so you will have to remove your local branch and re-pull if you want to get the changes locally.

This looks great though 😍 Review my changes quick and I'll get this in the next release!

@httpjamesm
Copy link
Contributor Author

Yup, looks good!

@aeharding aeharding merged commit 7cfbf22 into aeharding:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants