Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: segregate community list alphabetically #80

Merged

Conversation

httpjamesm
Copy link
Contributor

In Apollo, the community list is sorted alphabetically but also separated by their starting letter. This makes it much clearer and easier to find communities in long lists.

Comparison (Apollo first, Wefwef second):
Screenshot 2023-06-29 at 18 33 36
Screenshot 2023-06-29 at 18 33 53

@aeharding
Copy link
Owner

Looks AWESOME!

  1. Let's useMemo the lodash logic
  2. Can you remove the typescript as? I can take a look too, no big deal :)

@httpjamesm
Copy link
Contributor Author

Memoization done. I don't see a way to avoid using the as for the reduction map.

@aeharding
Copy link
Owner

Hi @httpjamesm, check out my changes and then I'll get this in for release tonight

@httpjamesm
Copy link
Contributor Author

That's better. I forgot about the <> type indicator

@aeharding aeharding merged commit ce8ad65 into aeharding:main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants