Skip to content

Commit

Permalink
FIX: failed genome variant search using internal id (#83)
Browse files Browse the repository at this point in the history
* FIX: convert error indices by pydantic to str form to generate the error messages

* Update documentation

* Update AUTH-GUIDE.md

* DEV: return resouce list for filtering_terms endpoints. updated data strcuture for Dynamodb Ontologies table

* Fixed map endpoint by removing static /api in the base URL mid-path (#81)

* This requires when registering into Beacon Network. It cannot
  be mis-matched with the actual deployed endpoints from terraform.

* DEV: Version pinning and layer upgrade

Python modules layer was updated, especially pydantic to V2. Versions are pinned in the init.sh file to avoid breaking changes affecting the deployments.

* FIX: variant search not working with id

Variant search used chrom name inside VCF file to search
this was not captured in get_matching_chromosome fucntion in shared.utils
added check to return chromosome name if VCF chromosome has same name as searched chromosome

---------

Co-authored-by: Victor San Kho Lin <victor@sankholin.com>
  • Loading branch information
anuradhawick and victorskl authored Jul 12, 2023
1 parent 2f278ae commit dbcd0c4
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@ def get_vcf_chromosomes(vcf):

def get_matching_chromosome(vcf_chromosomes, target_chromosome):
for vcf_chrom in vcf_chromosomes:
if _match_chromosome_name(vcf_chrom) == target_chromosome:
if vcf_chrom == target_chromosome:
return vcf_chrom
elif _match_chromosome_name(vcf_chrom) == target_chromosome:
return vcf_chrom
return None

Expand Down

0 comments on commit dbcd0c4

Please sign in to comment.