Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for recording, white led control, zoom and focus #55

Closed
wants to merge 2 commits into from

Conversation

Nibbels
Copy link
Contributor

@Nibbels Nibbels commented May 1, 2024

Servus :)

I did stumble across this issue some time ago #25
So I looked into it and worked on the adapter:

  • I split led mode from white led enable/disable settings
  • The adapter will now read led values (brightness, mode, switch) at adapter start. These values could be polled but I did not want to generate extra traffic until someone actually needs that.
  • Added a setter function for white led mode (Off, Night Smart Mode, Unknown, Timer)
  • Fix reading focus and zoom for ptz at adapter start. Focus is still a readonly because I could not find a way to set it to a specific integer value in the camera.
  • When I switch to other waypoints I want to avoid the auto focus procedure because it is slow. I tempered with the request for settings.autoFocus until all API errors were gone, but I could not find an actual change in behaviour when I switched the autoFocus value between "disable" and "not disable" autofocus.

Please review what I did. I tested with my two cameras RLC-823A and Duo 3 PoE - all looks good so far - but I can never know if something broke on other cameras. My firmwares are up-to-date.

Regards Stefan

Nibbels added 2 commits May 1, 2024 18:20
split led mode from white led settings
read led values (brightness, mode, switch) at adapter start
added white led mode setter
fix reading focus and zoom for ptz
cleanup
@Nibbels
Copy link
Contributor Author

Nibbels commented May 11, 2024

Das kam dazu: #56

@Nibbels Nibbels changed the title Update for white led, zoom and focus Update for recording, white led control, zoom and focus May 11, 2024
@Nibbels Nibbels mentioned this pull request May 11, 2024
Copy link
Collaborator

@oelison oelison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Collaborator

@oelison oelison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@oelison
Copy link
Collaborator

oelison commented May 11, 2024

Node 16 is failing. If it is okay I suggest to remove Node 16 as compatible version. (I start a pr on yours...)

@Nibbels
Copy link
Contributor Author

Nibbels commented May 12, 2024

Both commits are in the release branch.
I will close this PR because I think it is now unnecessary.

@Nibbels Nibbels closed this May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants