Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image field to EtcdCluster spec #63

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

sircthulhu
Copy link
Member

@sircthulhu sircthulhu commented Mar 22, 2024

Added image field to EtcdCluster spec, added tests and implemented defaulting webhook.
fixes #48

@sircthulhu sircthulhu added the feature New feature or request label Mar 22, 2024
@sircthulhu sircthulhu enabled auto-merge (squash) March 22, 2024 11:09
@sircthulhu sircthulhu force-pushed the feature/48-implement-spec-image branch from 651e5c4 to b45bd52 Compare March 23, 2024 09:15
@kvaps kvaps marked this pull request as draft March 26, 2024 15:58
auto-merge was automatically disabled March 26, 2024 15:58

Pull request was converted to draft

@sircthulhu sircthulhu force-pushed the feature/48-implement-spec-image branch from b45bd52 to 98f3dc5 Compare March 26, 2024 16:11
@sircthulhu sircthulhu self-assigned this Mar 26, 2024
@sircthulhu sircthulhu marked this pull request as ready for review March 26, 2024 16:12
@sircthulhu sircthulhu enabled auto-merge (squash) March 26, 2024 16:12
Copy link
Collaborator

@aobort aobort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sircthulhu sircthulhu merged commit 16bc8bc into main Mar 26, 2024
3 checks passed
@sircthulhu sircthulhu deleted the feature/48-implement-spec-image branch March 27, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement ".spec.image"
4 participants