Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor serviceentry controller #232

Merged
merged 3 commits into from
May 25, 2022

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented May 25, 2022

Use controller runtime api to rewrite the service entry controller.

@mergify mergify bot requested a review from zhaohuabing May 25, 2022 08:15
@Xunzhuo Xunzhuo force-pushed the refactor-serviceentry branch 2 times, most recently from c777921 to f271208 Compare May 25, 2022 08:27
Use controller runtime api to rewrite service entry controller.

Signed-off-by: Xunzhuo <mixdeers@gmail.com>
@Xunzhuo Xunzhuo force-pushed the refactor-serviceentry branch from f271208 to 4be85d3 Compare May 25, 2022 08:35
Xunzhuo added 2 commits May 25, 2022 16:37
Signed-off-by: Xunzhuo <mixdeers@gmail.com>
Signed-off-by: Xunzhuo <mixdeers@gmail.com>
@zhaohuabing zhaohuabing changed the title Refactor serviceentry Refactor serviceentry controller May 25, 2022
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 5048e76 into aeraki-mesh:master May 25, 2022
@Xunzhuo Xunzhuo deleted the refactor-serviceentry branch May 25, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants