fix bug for AERAKI_IS_MASTER env #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanjunchen
force-pushed
the
optimize-parameter
branch
from
20f0dac to
e8793b9
Compare
zhaohuabing
reviewed
Jun 10, 2023
| @@ -70,13 +70,17 @@ func main() { | |||
| args.ServerID = "Aeraki-" + uuid.New().String() | |||
| } | |||
|
|
|||
| args.PodName = env.RegisterStringVar("POD_NAME", args.ServerID, "").Get() | |||
There was a problem hiding this comment.
because the log of aeraki are:
2023-06-09T09:55:00.259687Z warn The environment variable POD_NAME was registered multiple times using different metadata: {POD_NAME false false 0}, {POD_NAME Aeraki-1d13822c-eca8-470f-a828-57938547f5f2 false false 0} 2023-06-09T09:55:00.259743Z info Aeraki parameter: aeraki-xds-address: aeraki.istio-system
PodName is be registered repeatly.
tanjunchen
force-pushed
the
optimize-parameter
branch
2 times, most recently
from
fa4660a to
159d1f6
Compare
Signed-off-by: chentanjun <tanjunchen20@gmail.com>
tanjunchen
force-pushed
the
optimize-parameter
branch
from
159d1f6 to
eb12dfa
Compare
zhaohuabing
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
fixed #353
Pre-Submission Checklist: