Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace io/ioutil to os/io in golang 1.19 #357

Merged
merged 1 commit into from
Jun 26, 2023
Merged

replace io/ioutil to os/io in golang 1.19 #357

merged 1 commit into from
Jun 26, 2023

Conversation

tanjunchen
Copy link
Member

What this PR does / Why we need it:

Pre-Submission Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added related test cases?
  • Have you modified the related document?
  • Is this PR backward compatible?

@tanjunchen
replace io/util to os/io in golang 1.19
94c7c97 
Signed-off-by: chentanjun <tanjunchen20@gmail.com>
@mergify mergify bot requested a review from zhaohuabing June 26, 2023 13:30
zhaohuabing
zhaohuabing approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaohuabing zhaohuabing merged commit 9038fa5 into aeraki-mesh:master Jun 26, 2023
@tanjunchen tanjunchen deleted the replace-io-util branch June 27, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaohuabing zhaohuabing zhaohuabing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanjunchen @zhaohuabing