Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused file #370

Merged
merged 1 commit into from
Jul 30, 2023
Merged

remove unused file #370

merged 1 commit into from
Jul 30, 2023

Conversation

tanjunchen
Copy link
Member

What this PR does / Why we need it:

ref# #366

Pre-Submission Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added related test cases?
  • Have you modified the related document?
  • Is this PR backward compatible?

@tanjunchen tanjunchen requested a review from zhaohuabing July 30, 2023 14:24
@tanjunchen
remove unused file
d5f2447 
Signed-off-by: chentanjun <tanjunchen20@gmail.com>
@tanjunchen tanjunchen force-pushed the delete-unused-code branch from c0029b3 to d5f2447 Compare July 30, 2023 14:25
zhaohuabing
zhaohuabing approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for cleaning up!

@mergify mergify bot merged commit 8afbabf into aeraki-mesh:master Jul 30, 2023
@tanjunchen tanjunchen deleted the delete-unused-code branch July 31, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaohuabing zhaohuabing zhaohuabing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanjunchen @zhaohuabing