Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust to istio 1.12.7 #58

Merged
merged 3 commits into from
May 22, 2022

Conversation

huanghuangzym
Copy link
Member

@huanghuangzym huanghuangzym commented May 19, 2022

fix for aeraki-mesh/aeraki#222

aeraki contrl plane have already adjust to istio 1.12.7

but meta-protocol-proxy build with envoy 1.18 (istio 1.10)

this pr is used to adjust to envoy 1.20(istio 1.12)

@huanghuangzym
Copy link
Member Author

envoyproxy/envoy@v1.18.6...v1.20.3
between envoy 1.18.6 and 1.20.3
some files move dirs
some interfce has changed
version-convert lib removed

@zhaohuabing
Copy link
Member

@huanghuangzym thanks for your contrition. This pr is great.

Without CI and auto testing, I'll have to pull your branch and test locally. It may take some time to get this PR approved.

Now CI becomes a roadblock for our PR reviews. Hope some one could help on it.

@huanghuangzym
Copy link
Member Author

@huanghuangzym thanks for your contrition. This pr is great.

Without CI and auto testing, I'll have to pull your branch and test locally. It may take some time to get this PR approved.

Now CI becomes a roadblock for our PR reviews. Hope some one could help on it.

yes ,CI is needed, we should use github action to build it as soon as?
i build it in local,and run some protocol test is ok, and i think it must need more test (we will run more test in alauda )
if any question , anyone can add commit to this branch

BUILD Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@huanghuangzym huanghuangzym requested a review from smwyzi May 20, 2022 01:30
@huanghuangzym huanghuangzym force-pushed the feat/adjust-istio1-12-7 branch from 46c0d5f to 0c8e845 Compare May 20, 2022 01:44
adjust tab ident size
@huanghuangzym huanghuangzym force-pushed the feat/adjust-istio1-12-7 branch from 0c8e845 to f6ea054 Compare May 20, 2022 01:45
@smwyzi
Copy link
Contributor

smwyzi commented May 20, 2022

LGTM

Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaohuabing zhaohuabing merged commit b249f70 into aeraki-mesh:master May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants