-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjust to istio 1.12.7 #58
adjust to istio 1.12.7 #58
Conversation
envoyproxy/envoy@v1.18.6...v1.20.3 |
@huanghuangzym thanks for your contrition. This pr is great. Without CI and auto testing, I'll have to pull your branch and test locally. It may take some time to get this PR approved. Now CI becomes a roadblock for our PR reviews. Hope some one could help on it. |
yes ,CI is needed, we should use github action to build it as soon as? |
46c0d5f
to
0c8e845
Compare
adjust tab ident size
0c8e845
to
f6ea054
Compare
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix for aeraki-mesh/aeraki#222
aeraki contrl plane have already adjust to istio 1.12.7
but meta-protocol-proxy build with envoy 1.18 (istio 1.10)
this pr is used to adjust to envoy 1.20(istio 1.12)