-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composable Transactions #182
Conversation
It seems able to make 'multicall contract', which call multiple contract in contract. Is there a difference between multiple contracts in a transaction and multiple contracts in a contract? and also, i suspect there isn`t rollback state appropriately when composable transaction failed. |
composable transaction can execute multiple signatures atomically, but it also can by multisig in one transaction. |
I honestly cannot understand what you wrote
I will add failure cases to the unit tests
what do you mean by "signatures"? what is "multisig in one transaction"? what do you want to say with the above sentence? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This implements the feature of Composable Transactions