Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composable Transactions #182

Merged
merged 57 commits into from
Aug 15, 2024
Merged

Conversation

kroggen
Copy link
Member

@kroggen kroggen commented Aug 16, 2022

This implements the feature of Composable Transactions

@kroggen kroggen requested a review from qcollapse August 16, 2022 06:01
@kroggen kroggen added the feature New feature or request label Sep 28, 2023
@kroggen kroggen removed the request for review from qcollapse October 16, 2023 11:17
@kroggen kroggen changed the base branch from release/2.4.0 to develop November 25, 2023 14:17
@kroggen kroggen changed the base branch from develop to topic/hardfork-v4 November 25, 2023 18:40
@kroggen kroggen added the V4 To be released on hardfork V4 label Dec 13, 2023
@rabbitprincess
Copy link
Member

rabbitprincess commented Dec 15, 2023

It seems able to make 'multicall contract', which call multiple contract in contract. Is there a difference between multiple contracts in a transaction and multiple contracts in a contract?

and also, i suspect there isn`t rollback state appropriately when composable transaction failed.

@rabbitprincess
Copy link
Member

composable transaction can execute multiple signatures atomically, but it also can by multisig in one transaction.

@kroggen
Copy link
Member Author

kroggen commented Dec 15, 2023

It seems able to make 'multicall contract', which call multiple contract in contract. Is there a difference between multiple contracts in a transaction and multiple contracts in a contract?

I honestly cannot understand what you wrote

and also, i suspect there isn`t rollback state appropriately when composable transaction failed.

I will add failure cases to the unit tests

composable transaction can execute multiple signatures atomically, but it also can by multisig in one transaction.

what do you mean by "signatures"?

what is "multisig in one transaction"?

what do you want to say with the above sentence?

Copy link
Member

@hayarobi hayarobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kroggen kroggen merged commit 949b4b0 into topic/hardfork-v4 Aug 15, 2024
3 checks passed
@kroggen kroggen added V4 To be released on hardfork V4 and removed V5 To be released on hardfork V5 labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request V4 To be released on hardfork V4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants