Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SVG attributes preserve aspect ratio and view box #170

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix SVG attributes preserve aspect ratio and view box #170

wants to merge 2 commits into from

Conversation

ashadulhoque
Copy link

lxml processing at class EpubHtml converts preserveAspectRatio and viewBox svg attributes to lowercase which generates epub validation error and resultant epub cover doesn't cover full page as it should. This hack restores the case of these attributes.

@james-c-barnes
Copy link

Just ran into this bug; 'viewBox' is renamed to 'viewbox'. Code hack works. I needed to convert the strings to bytes

        # https://github.com/aerkalov/ebooklib/pull/170
        tree_str = tree_str.replace(b'preserveaspectratio',b'preserveAspectRatio')
        tree_str = tree_str.replace(b'viewbox',b'viewBox')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashadulhoque @james-c-barnes