Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option for additional parameters #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MrChrisBarker
Copy link

Motivation

Recent requirement from my our API squad led for the requirements or specific brand parameters to be passed into the request.

What

Updated the oAuth model to concatenate optional additional URL parameters, these can be passed into Config class as an optional parameter.

Why

Same reason behind the motivation.

How

Optional parameter added to Config constructor.

Verification Steps

  1. Create new instance of Config (or class that inherits from Config)
  2. Add Dictionary() of [String: String] to newly available optional parameter
  3. Verify URL is created correctly.

Checklist:

  • [X ] Code has been tested locally by PR requester
  • Changes have been successfully verified by another team member

Progress

  • Finished task
  • TODO

Additional Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant