Templates for Relay frontend #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add.js.template - simple screen with a form with all input fields of the mutation from schema.json, it commit mutation onSubmit AddMutation.js.template - simple add mutation template Edit.js.template - simple screen with a form to edit a graphql object type EditMutation.js.template - simple edit mutation template List.js.template - list of objects from relay View.js.template - tabbed detail view of graphql object type WIP of #12
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
+ Coverage 59.01% 66.46% +7.45%
==========================================
Files 13 22 +9
Lines 305 334 +29
==========================================
+ Hits 180 222 +42
+ Misses 125 112 -13
Continue to review full report at Codecov.
|
lucasbento
reviewed
Jan 4, 2017
| ]; | ||
|
|
||
| onSubmit = (data) => { | ||
| const { company } = this.props; |
There was a problem hiding this comment.
This should be const { <%= camelCasedName %> } = this.props;.
| onSubmit = (data) => { | ||
| const { company } = this.props; | ||
|
|
||
| const mutation = new <%= rawName %>EditMutation({ |
There was a problem hiding this comment.
Should be name instead of rawName.
| <%= rawName %>: () => Relay.QL` | ||
| fragment on <%= name %> { | ||
| id | ||
| ${<%= name %>EditMutation.getFragment('<%= rawName %>')} |
There was a problem hiding this comment.
<%= camelCasedName %> instead of rawName.
| }; | ||
|
|
||
| render() { | ||
| const { <%= rawName %> } = this.props; |
There was a problem hiding this comment.
<%= camelCasedName %> instead of rawName.
| <Form | ||
| fields={this.fields} | ||
| onSubmit={this.onSubmit} | ||
| value={<%= rawName %>} |
There was a problem hiding this comment.
<%= camelCasedName %> instead of rawName.
| label: 'Details', | ||
| component: ( | ||
| <FlightEdit | ||
| <%= rawName %>={<%= rawName %>} |
| const tabs = [{ | ||
| label: 'Details', | ||
| component: ( | ||
| <FlightEdit |
|
|
||
| return ( | ||
| <div> | ||
| <h1 style={styles.title}><%= name %>: {<%= rawName %>.id}</h1> |
There was a problem hiding this comment.
camelCaseName instead of rawName.
| fragments: { | ||
| viewer: ({ id }) => Relay.QL` | ||
| fragment on Viewer { | ||
| <%= rawName %>(id: $id) { |
There was a problem hiding this comment.
camelCaseName instead of rawName.
| fragment on Viewer { | ||
| <%= rawName %>(id: $id) { | ||
| id | ||
| ${<%= name %>Edit.getFragment('<%= rawName %>')} |
sibelius
force-pushed
the
feature/template_frontend
branch
2 times, most recently
from
8e12098
to
16ae274
Compare
Add.js.template - simple screen with a form with all input fields of the mutation from schema.json, it commit mutation onSubmit AddMutation.js.template - simple add mutation template Edit.js.template - simple screen with a form to edit a graphql object type EditMutation.js.template - simple edit mutation template List.js.template - list of objects from relay View.js.template - tabbed detail view of graphql object type WIP of #12
sibelius
force-pushed
the
feature/template_frontend
branch
from
16ae274
to
679f906
Compare
4 tasks
…feature/template_frontend
…ature/template_frontend
…into feature/template_frontend
|
modern FWI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add.js.template - simple screen with a form with all input fields
of the mutation from schema.json, it commit mutation onSubmit
AddMutation.js.template - simple add mutation template
Edit.js.template - simple screen with a form to edit a graphql object type
EditMutation.js.template - simple edit mutation template
List.js.template - list of objects from relay
View.js.template - tabbed detail view of graphql object type
WIP of #12
TODO
withSchema, read types fromschema.json