-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keycloak 25 compatibility #204
Keycloak 25 compatibility #204
Conversation
+ changed to io.quarkus.resteasy.reactive:resteasy-reactive + changed quarkus-resteasy.version to 3.8.5 - removed filter for deprecated and incompatible Wildfly / JBossEAP
+1 thanks @jannickherrmann ! |
👍 Keycloak will eventually drop support for JDK <21 https://www.keycloak.org/docs/latest/release_notes/#java-17-support-is-deprecated |
Yes, I read that too, but since it is currently "only" deprecated and has not yet been removed, I haven't touched it yet. It's my first pull request in this repository, so I didn't want to make too big a change straight away. |
👍 I can also confirm that this snapshot works with my Keycloak 25.0 setup. |
If useful, here's the JAR built from @jannickherrmann's repository branch keycloak-metrics-spi-5.0.1-SNAPSHOT.jar.zip (had to stupidly ZIP-it otherwise attachment not allowed in Github comment)
|
Thanks @nicolabeghin for the downloadable link and |
👀 |
Is there something holding this from being mereged? |
thanks @jannickherrmann ! I suppose this will no longer work on older versions on KeyCloak? Sorry for the delay on my end. |
@pb82 I haven't actually checked, but the changeover was carried out over several major versions of Keycloak, so it should also be downward compatible or compatible with certain versions. Already in Keycloak 23 the resteasy-reactive were used, only the resteasy-core was not completely removed. |
Motivation
I want to use the metrics spi with the newest keycloak version.
Releated issue: #199
What
Migrating to compatible RESTEasy Reactive dependencies.
Why
The current implementation is incompatible with Keycloak 25 due to the complete transition to RESTEasy Reactive. See issue: keycloak/keycloak#29223.
How
Both the Maven
pom.xml
and thebuild.gradle
files have been updated to reflect the new dependencies. Additionally, support for WildFly JBoss has been removed because the code could not be easily migrated to the reactive dependencies. Moreover, I do not see a necessity for maintaining WildFly support: https://www.keycloak.org/migration/migrating-to-quarkus.Verification Steps
mvn compile
or./gradlew build
to verifyChecklist:
Progress
Additional Notes