use aerogearcatalog custom Grafana image #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works all right 👍 |
josemigallas
approved these changes
Feb 5, 2018
Merged
5 tasks
|
Ignore my previous comment, tested locally and worked: i didn't need to restart grafana after keycloak deployment. The dashboard was available 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Myself and @StevenTobin have built a custom Grafana image based off the Grafana master branch at a certain point in time. The image also has the pie chart panel and worldmap panel plugins baked in baked in by default.
It's been pushed to https://hub.docker.com/r/aerogearcatalog/grafana/. This PR switches us over to using that image. (also minor side note: it also enables debug logging in Grafana by default)
Why?
We're using features that are only available on the master branch of Grafana. These features will become GA with the Grafana 5.0 release in the next few months. Right now the problem is the master branch is pretty unstable. We've run into a couple of issues where dashboard and datasource discovery stopped working. The custom image will help us avoid these kinds of issues by locking us down to a commit that is known to be pretty stable.
We currently have issues where we cannot install any plugins into Grafana running in OpenShift. We haven't worked out a good solution yet but we need something in place because the keycloak dashboard depends on plugins. See the discussion at Adds a Grafana dashboard for the metrics gathered in Prometheus keycloak-apb#33 (review) to better understand the plugins issue.
The approach of baking the plugins is not the best. We tried an approach where the plugins would be installed at startup time using an environment variable but there were issues where Grafana wouldn't start up as a result. We think this may be a bug in Grafana itself. However, this should keep us going for the time being as we figure out a better solution.
cc @david-martin
Edit: I forgot to mention, we made a fork of the grafana build tools repo here: https://github.com/aerogear/grafana-docker
This was the repo used to build and push the docker image to dockerhub.