Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: split video args #289

Merged
merged 1 commit into from
Feb 19, 2021
Merged

fix: split video args #289

merged 1 commit into from
Feb 19, 2021

Conversation

lxShaDoWxl
Copy link

if usage
cm selenoid start --vnc --tmpfs 128 --args "-video-recorder-image docker.io/selenoid/video-recorder:7.1"
to arg video-recorder-image dublicate need usage
cm selenoid start --vnc --tmpfs 128 --args "-video-recorder-image docker.io/selenoid/video-recorder:7.1 -video-output-dir /opt/selenoid/video/"
this incorrect work

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #289 (b3c4fb1) into master (a491e7c) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
+ Coverage   67.69%   67.75%   +0.06%     
==========================================
  Files           4        4              
  Lines        1040     1042       +2     
==========================================
+ Hits          704      706       +2     
  Misses        229      229              
  Partials      107      107              
Flag Coverage Δ
go 67.75% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
selenoid/docker.go 73.53% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 103d482...b3c4fb1. Read the comment docs.

@vania-pooh vania-pooh merged commit c0c040e into aerokube:master Feb 19, 2021
@vania-pooh
Copy link
Member

@lxShaDoWxl thank you for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants