Skip to content
This repository has been archived by the owner on Dec 17, 2024. It is now read-only.

Non-latin symbols support #8

Closed
vania-pooh opened this issue Jun 28, 2017 · 25 comments
Closed

Non-latin symbols support #8

vania-pooh opened this issue Jun 28, 2017 · 25 comments

Comments

@vania-pooh
Copy link
Member

955dcf95-73b2-4b6d-8fae-f1f6052b2831
With current images we get tofu instead of Chinese symbols.

@ikuznechikova
Copy link

2017-06-30_1126
I have a problem not only with Chinese, but also with Korean, Chinese, Arabic symbols. Reproduced in all versions Selenoid(firefox, chrome, opera)

@vania-pooh
Copy link
Member Author

Ok, will take a look during the weekend.

@vania-pooh
Copy link
Member Author

Found an easy solution: need to install one more fonts package fonts-noto-cjk. The only issue is - installing this package adds 100 Mb of fonts. Investigating how to obtain the same result spending less disk space.

@vania-pooh
Copy link
Member Author

An alternative Chinese fonts are in package fonts-wqy-zenhei (17 Mb).

@vania-pooh
Copy link
Member Author

vania-pooh commented Jul 7, 2017

Created 2 test images: vaniapooh/firefox:54.0_noto and vaniapooh/firefox:54.0_zenhei.

@ikuznechikova
Copy link

ikuznechikova commented Jul 11, 2017

vania-pooh commented 4 days ago
Created 2 test images: vaniapooh/firefox:54.0_noto and vaniapooh/firefox:54.0_zenhei.

image

Ivan, thank you! Now that's better, but add a display of Thai symbols, please.

@vania-pooh
Copy link
Member Author

@ikuznechikova thai still does not work even with noto image?

@ikuznechikova
Copy link

Unfortunately, thai symbols doesn't work neither in noto nor in zenhei images. See screenshot above.

@vania-pooh
Copy link
Member Author

Ok, will check that.

@vania-pooh
Copy link
Member Author

@ikuznechikova In order to support Thai we need to install fonts-thai-tlwg-ttf package (adds 8 megabytes to image). Please test with the following image: vaniapooh/firefox:54.0_zenhei_thai - it contains both Chinese and Thai support.

@ikuznechikova
Copy link

@vania-pooh , thank you very much! Now all the necessary symbols (Chinese, Thai, Korean) are displayed in the browser of the image: vaniapooh/firefox:54.0_zenhei_thai
lang

@vania-pooh
Copy link
Member Author

Good. Will need to apply these changes to all images.

@trysh
Copy link

trysh commented Aug 27, 2017

thank you !
When to apply these changes to all images (selenoid/chrome selenoid/firefox ...)?

@vania-pooh
Copy link
Member Author

We are currently thinking about one more improvement related to logging. Will update this issue when this is done. Updating all 100+ images is a lot of work and will cause users to redownload a lot of stuff. We should think a bit more before doing such changes.

@vania-pooh
Copy link
Member Author

While waiting for this issue to be fixed here is an example Dockerfile how to customize fonts:

FROM selenoid/vnc:firefox_54.0

RUN \
    apt-get update && \
    apt-get -y --no-install-recommends install fonts-wqy-zenhei fonts-thai-tlwg-ttf && \
    apt-get clean && \
    rm -Rf /tmp/*

@vania-pooh
Copy link
Member Author

vania-pooh commented Sep 27, 2017

Possible Japanese font packages: fonts-ipafont-mincho fonts-ipafont-gothic.

@vania-pooh vania-pooh changed the title Chinese symbols support Non-latin symbols support Sep 27, 2017
@vania-pooh
Copy link
Member Author

Pushed an example image of what I would like to add to all browser images - vaniapooh/firefox:56.0. It includes fonts as well as encodings. Please test whether fonts are OK.

@ikuznechikova
Copy link

ikuznechikova commented Nov 7, 2017

@vania-pooh
It was checked the display of non-Latin (Korean, Thai, Chinese, Japanese) symbols in the image vaniapooh/firefox:56.0, the test ok
image

image

@vania-pooh
Copy link
Member Author

@ikuznechikova ok, will prepare more images.

@arslanbekov
Copy link

@vania-pooh hi, no news? We are really looking forward to :)

@vania-pooh
Copy link
Member Author

@arslanbekov will start rebuilding today. Which browsers are more important? I could e.g. first of all rebuild all Chrome or Firefox images.

@arslanbekov
Copy link

arslanbekov commented Nov 14, 2017

The most necessary — Chrome

@vania-pooh
Copy link
Member Author

Agreed.

@vania-pooh
Copy link
Member Author

vania-pooh commented Nov 15, 2017

Forgot to add hindi fonts. Possible solution - fonts-deva. Test page: https://hi.wikipedia.org/wiki/%E0%A4%AE%E0%A5%81%E0%A4%96%E0%A4%AA%E0%A5%83%E0%A4%B7%E0%A5%8D%E0%A4%A0

@vania-pooh
Copy link
Member Author

After a month of intensive work this is finally fixed. All images are supporting new fonts and video recording.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants