fix image creation with local debian packages #418
Conversation
Codecov Report
@@ Coverage Diff @@
## master #418 +/- ##
=========================================
- Coverage 6.40% 6.24% -0.17%
=========================================
Files 7 7
Lines 765 785 +20
=========================================
Hits 49 49
- Misses 709 729 +20
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@lorsatti sorry for the delay. Being on vacation and will check in detail during next days. |
|
@vania-pooh Np. Enjoy your vacation! |
build/chrome.go
Outdated
| @@ -40,7 +40,11 @@ func (c *Chrome) Build() error { | |||
|
|
|||
| if pkgSrcPath != "" { | |||
| srcDir = "chrome/local" | |||
| pkgDestPath := filepath.Join(devDestDir, "google-chrome.deb") | |||
| err := os.MkdirAll(devDestDir+"/"+srcDir, 0755) | |||
There was a problem hiding this comment.
Should use filepath.Join to make file path separator platform-independent. Just declare pkgDestDir := filepath.Join(devDestDir, srcDir) and also use this value in pkgDestPath initialization.
build/edge.go
Outdated
| @@ -33,7 +33,11 @@ func (c *Edge) Build() error { | |||
|
|
|||
| if pkgSrcPath != "" { | |||
| srcDir = "edge/local" | |||
| pkgDestPath := filepath.Join(devDestDir, "microsoft-edge.deb") | |||
| err := os.MkdirAll(devDestDir+"/"+srcDir, 0755) | |||
build/firefox.go
Outdated
| @@ -40,7 +40,11 @@ func (c *Firefox) Build() error { | |||
|
|
|||
| if pkgSrcPath != "" { | |||
| devSrcDir = "firefox/local" | |||
| pkgDestPath := filepath.Join(devDestDir, "firefox.deb") | |||
| err := os.MkdirAll(devDestDir+"/"+devSrcDir, 0755) | |||
build/opera.go
Outdated
| @@ -31,7 +31,11 @@ func (o *Opera) Build() error { | |||
|
|
|||
| if pkgSrcPath != "" { | |||
| srcDir = "opera/local" | |||
| pkgDestPath := filepath.Join(devDestDir, "opera.deb") | |||
| err := os.MkdirAll(devDestDir+"/"+srcDir, 0755) | |||
build/yandex.go
Outdated
| @@ -31,7 +31,11 @@ func (yb *YandexBrowser) Build() error { | |||
|
|
|||
| if pkgSrcPath != "" { | |||
| srcDir = "yandex/local" | |||
| pkgDestPath := filepath.Join(devDestDir, "yandex-browser.deb") | |||
| err := os.MkdirAll(devDestDir+"/"+srcDir, 0755) | |||
|
@lorsatti thank you for contribution! |
Related to #417.