Use relative source path in exceptions #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denizevrenci
suggested changes
Nov 29, 2018
| @@ -55,6 +55,9 @@ if(NOT CMAKE_BUILD_TYPE) | |||
| set(CMAKE_BUILD_TYPE "Release" CACHE STRING "Choose the type of build" FORCE) | |||
| endif(NOT CMAKE_BUILD_TYPE) | |||
|
|
|||
| # relative file paths for use in exceptions | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -D__CMAKE_SOURCE_DIR__='\"${CMAKE_SOURCE_DIR}\"'") | |||
There was a problem hiding this comment.
I know I suggested passing CMAKE_SOURCE_DIR but on second thought, it would be better to pass PROJECT_SOURCE_DIR.
If Aeron project is included by another project with add_subdirectory, CMAKE_SOURCE_DIR will point to the containing project's source directory while PROJECT_SOURCE_DIR will still point to Aeron's project root.
This will not affect standalone builds.
There was a problem hiding this comment.
This seems reasonable to me. Please speak up if anyone else has opinions, I can change if not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have sourced exceptions contain text that looks like aeron-client/.../filename instead of /home/luke/aeron/aeron-client....
Note that #555 was a previous attempt at this.