Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round-off error fixed and complex roots simplified #38

Merged
merged 6 commits into from
Mar 5, 2018
Merged

Round-off error fixed and complex roots simplified #38

merged 6 commits into from
Mar 5, 2018

Conversation

8hantanu
Copy link
Member

@8hantanu 8hantanu commented Mar 4, 2018

The complex roots have been simplified to sqrt[2]{-1.0} and the rounding-off of roots is rectified.

For example, the output for Find Roots for a quadratic equation like
x^2 + 2x + 5 = 0
was
{ x + 1.0 + 0 * sqrt[2]{-16.0} } * { x + 1.0 - 0 * sqrt[2]{-16.0} } = 0
which is now corrected to
{ x + 1.0 + 2.0 * sqrt[2]{-1.0} } * { x + 1.0 - 2.0 * sqrt[2]{-1.0} } = 0

I will try to add a new token called 'cmplx' which will handle 'sqrt[2]{-1.0}' as 'j' and will enable complex input.

@sidkothiyal
Copy link
Member

@8hantanu great thanks

@sidkothiyal sidkothiyal merged commit 6b21ad7 into aerospaceresearch:master Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants