Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodejs-Release-5.8.0 #581

Merged
merged 22 commits into from
Sep 28, 2023
Merged

Nodejs-Release-5.8.0 #581

merged 22 commits into from
Sep 28, 2023

Conversation

DomPeliniAerospike
Copy link
Collaborator

No description provided.

CLIENT-2378
Add exp.inf and exp.wildcard methods
Add testing for exp.inf, exp.nil, and exp.wildcard
…moveBy methods

CLIENT-2488 & CLIENT-2538
Fixed segmentation fault occuring exp.maps.removeBy* and exp.lists.removeBy methods
Fixed opcodes in exp.list.getByKeyList, exp.list.getByKeyRelIndexRangeToEnd, exp.getByValueList methods
Added testing for all fixed methods.
… in put operations.

CLIENT-1983
Added Bin class.
Added support for the Bin class in put operations.
Added support for Javascript Maps in put operations.
Note: Javascript Maps become Key Ordered Maps before being sent to the server.
Switched from Ink-docstrap to Docdash for API documentation generation.
Fixed segmentation fault occuring exp.maps.removeBy* and exp.lists.re…
Switched from Ink-docstrap to Docdash
Added Bin class and support for Javascript Maps and the new Bin class…
Add exp.inf and exp.wildcard methods
CLIENT-2374
Added Typescript typings file.
Organized typescript components in alphabetical order.
Fixed casting error.
Fixed putItems test case.
ran npm lint.
Removed v16 and v19  from Build script and github actions.
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (fca26d2) 91.66% compared to head (b3057a0) 91.25%.
Report is 23 commits behind head on master.

❗ Current head b3057a0 differs from pull request most recent head 2c5f49e. Consider uploading reports for the commit 2c5f49e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #581      +/-   ##
==========================================
- Coverage   91.66%   91.25%   -0.42%     
==========================================
  Files          62       69       +7     
  Lines        2124     2229     +105     
==========================================
+ Hits         1947     2034      +87     
- Misses        177      195      +18     
Files Coverage Δ
lib/admin.js 100.00% <100.00%> (ø)
lib/aerospike.js 97.33% <100.00%> (+0.15%) ⬆️
lib/commands/index.js 100.00% <100.00%> (ø)
lib/error.js 97.14% <ø> (ø)
lib/exp.js 100.00% <100.00%> (ø)
lib/exp_lists.js 89.09% <100.00%> (+21.81%) ⬆️
lib/exp_maps.js 82.53% <100.00%> (+30.15%) ⬆️
lib/policies/info_policy.js 100.00% <ø> (ø)
lib/privilege_code.js 100.00% <100.00%> (ø)
lib/scan.js 85.71% <100.00%> (+0.20%) ⬆️
... and 9 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DomPeliniAerospike and others added 11 commits September 22, 2023 09:15
Fixed AerospikeError Api documentation
Modifiied README.md
Modified incompatible.md
Updated Version information
Modified preBuiltBinding.js
Fixed variable issue
Updated install script for windows compatibility.
Updated typings.
installed npm-run-all package
Ran npm update and npm update -D
Renamed prebuild to removeExtraBinaries
Removed npm-run-all for npm run
Added correct build script
Fixed prebuilt binding scripts to remove correct versions
Copy link
Contributor

@mcoberly2 mcoberly2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcoberly2 mcoberly2 merged commit 4d2929f into master Sep 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants