Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smalls fixes around getListType and getMapType #632

Merged
merged 5 commits into from
Sep 3, 2024

Conversation

DomPeliniAerospike
Copy link
Collaborator

No description provided.

DomPeliniAerospike and others added 4 commits June 5, 2024 10:24
Adding maps types to expressions return type
Added type checking for valueType parameter

Modified error messages

Ran npm lint
realmgic
realmgic previously approved these changes Aug 30, 2024
Copy link
Member

@realmgic realmgic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@DomPeliniAerospike
Copy link
Collaborator Author

Added similar code for EXISTS. Merging to stage now.

@DomPeliniAerospike DomPeliniAerospike merged commit a99b18f into stage Sep 3, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants