Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-2604] Add support for persisting map indexes #534

Merged
merged 7 commits into from
Oct 19, 2023

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Oct 12, 2023

@juliannguyen4 juliannguyen4 added the new-server-features Test against the latest server release candidate label Oct 12, 2023
@juliannguyen4 juliannguyen4 marked this pull request as ready for review October 12, 2023 21:28
@juliannguyen4 juliannguyen4 removed the request for review from dwelch-spike October 12, 2023 21:28
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4d653b2) 81.29% compared to head (d37c0bf) 81.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #534      +/-   ##
==========================================
+ Coverage   81.29%   81.33%   +0.04%     
==========================================
  Files          98       98              
  Lines       14766    14783      +17     
==========================================
+ Hits        12004    12024      +20     
+ Misses       2762     2759       -3     
Files Coverage Δ
aerospike_helpers/operations/bitwise_operations.py 100.00% <ø> (ø)
src/main/client/operate.c 91.60% <100.00%> (+0.14%) ⬆️
src/main/policy.c 84.23% <100.00%> (-0.07%) ⬇️
aerospike_helpers/operations/map_operations.py 98.57% <85.71%> (-0.45%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 force-pushed the CLIENT-2604-persistent-map-indexes branch from b5cea99 to 67819ad Compare October 17, 2023 18:17
@juliannguyen4 juliannguyen4 force-pushed the CLIENT-2604-persistent-map-indexes branch from 1280a80 to d37c0bf Compare October 18, 2023 21:00
Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

@juliannguyen4 juliannguyen4 merged commit 48b3a01 into stage Oct 19, 2023
43 of 45 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-2604-persistent-map-indexes branch October 19, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-server-features Test against the latest server release candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants