CDT updates #69
Merged
CDT updates #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement new get_by_* & remove_by_* list operations * Implement support for Ordered & Unique Lists: * Add sort & set_order ops * Add sort order list policy for list creation * Add add_unique, no_fail, partial list write flags
The of the map order in the map operations is difficult, if not impossible, for the client to verify, so there isn't much point in testing this at all.
Write flags replace the existing write mode; requires server version 4.3 or later.
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
- Coverage 95.22% 94.92% -0.31%
==========================================
Files 147 153 +6
Lines 8968 9894 +926
==========================================
+ Hits 8540 9392 +852
- Misses 428 502 +74
Continue to review full report at Codecov.
|
Server behaviour for failed, insert-bounded list operations has changed in v4.3.0: Older server fail silently while newer servers return a parameter error.
jhecking
added a commit
that referenced
this pull request
Aug 1, 2018
* master: CDT list/map updates (#69)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support all current CDT server side operations: