Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vec 266 Add a node ls command #9

Merged
merged 21 commits into from
Aug 8, 2024
Merged

Vec 266 Add a node ls command #9

merged 21 commits into from
Aug 8, 2024

Conversation

jdogmcsteezy
Copy link

  • Add a new node ls command.
  • Added new test scenarios that run multiple nodes with and without an LB. These tests currently only test the node ls command.
  • Create a new workflow that only runs on PR that runs the multi node scenarios.

@jdogmcsteezy jdogmcsteezy changed the title Vec 266 Vec 266 Add a node ls command Aug 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 56.90516% with 259 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@8f1b95d). Learn more about missing BASE report.

Files Patch % Lines
tests/utils.go 0.00% 90 Missing ⚠️
tests/base_suite.go 0.00% 63 Missing ⚠️
cmd/nodeList.go 74.05% 53 Missing and 9 partials ⚠️
cmd/writers/nodeList.go 78.94% 8 Missing and 4 partials ⚠️
cmd/view.go 76.08% 11 Missing ⚠️
cmd/writers/utils.go 81.25% 4 Missing and 2 partials ⚠️
cmd/writers/indexList.go 78.57% 1 Missing and 2 partials ⚠️
cmd/writers/roleList.go 70.00% 1 Missing and 2 partials ⚠️
cmd/writers/userList.go 75.00% 1 Missing and 2 partials ⚠️
cmd/indexList.go 50.00% 1 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage        ?   73.91%           
=======================================
  Files           ?       40           
  Lines           ?     2557           
  Branches        ?        0           
=======================================
  Hits            ?     1890           
  Misses          ?      579           
  Partials        ?       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks, understanding questions, and a nginx config error. Once you have had a look I will approve.

cmd/node.go Outdated Show resolved Hide resolved
cmd/node.go Outdated Show resolved Hide resolved
cmd/node_list.go Outdated Show resolved Hide resolved
cmd/node_list.go Outdated Show resolved Hide resolved
cmd/node_list.go Outdated Show resolved Hide resolved
cmd/node_list.go Outdated Show resolved Hide resolved
cmd/root.go Show resolved Hide resolved
cmd/writers/nodeList.go Show resolved Hide resolved
cmd/writers/utils.go Outdated Show resolved Hide resolved
docker/multi-node-LB/config/nginx.conf Outdated Show resolved Hide resolved
@dwelch-spike dwelch-spike self-requested a review August 8, 2024 20:49
Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the tests pass this LGTM

@jdogmcsteezy jdogmcsteezy merged commit accf86d into main Aug 8, 2024
4 of 6 checks passed
@jdogmcsteezy jdogmcsteezy deleted the VEC-266 branch August 8, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants