Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI setup and remove Python 3.7 #94

Merged
merged 8 commits into from
Feb 16, 2023

Conversation

brandonwillard
Copy link
Member

@brandonwillard brandonwillard commented Feb 3, 2023

This PR updates the CI setup to better reflect Aesara's setup. It also removes explicit support for Python 3.7.

@brandonwillard brandonwillard added the CI Continuous Integration label Feb 3, 2023
@brandonwillard brandonwillard changed the title Update CI setup Update CI setup and remove Python 3.7 Feb 3, 2023
@maresb
Copy link
Contributor

maresb commented Feb 4, 2023

https://github.com/aesara-devs/aemcmc/actions/runs/4088898918/jobs/7051043531#step:6:597

FAILED tests/test_basic.py::test_create_gibbs - ValueError: n too large or p too small, see Generator.negative_binomial Notes
Apply node that caused the error: nbinom_rv{0, (0, 0), int64, True}(RandomGeneratorSharedVariable(<Generator(PCG64) at 0x7FEE1823E340>), TensorConstant{[]}, TensorConstant{4}, h, Elemwise{Composite{sigmoid((-i0))}}[(0, 0)].0)
Toposort index: 72
Inputs types: [RandomGeneratorType, TensorType(int64, (0,)), TensorType(int64, ()), TensorType(float64, ()), TensorType(float64, (?,))]
Inputs shapes: ['No shapes', (0,), (), (), (100,)]
Inputs strides: ['No strides', (0,), (), (), (8,)]
Inputs values: [Generator(PCG64) at 0x7FEE1823E340, array([], dtype=int64), array(4), array(106.86324627), 'not shown']
Outputs clients: [['output'], []]

HINT: Re-running with most Aesara optimizations disabled could provide a back-trace showing when this node was created. This can be done by setting the Aesara flag 'optimizer=fast_compile'. If that does not work, Aesara optimizations can be disabled with 'optimizer=None'.
HINT: Use the Aesara flag `exception_verbosity=high` for a debug print-out and storage map footprint of this Apply node.

@brandonwillard
Copy link
Member Author

FYI: The error is due to #96.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 98.28% // Head: 98.16% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (e7e4031) compared to base (6979561).
Patch coverage: 95.45% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   98.28%   98.16%   -0.12%     
==========================================
  Files          10       10              
  Lines         698      708      +10     
  Branches       62       63       +1     
==========================================
+ Hits          686      695       +9     
  Misses          5        5              
- Partials        7        8       +1     
Impacted Files Coverage Δ
aemcmc/conjugates.py 100.00% <ø> (ø)
aemcmc/ffbs.py 100.00% <ø> (ø)
aemcmc/nuts.py 98.50% <ø> (ø)
aemcmc/transforms.py 100.00% <ø> (ø)
aemcmc/types.py 100.00% <ø> (ø)
aemcmc/rewriting.py 98.07% <90.90%> (-0.60%) ⬇️
aemcmc/basic.py 100.00% <100.00%> (ø)
aemcmc/gibbs.py 95.36% <100.00%> (-0.08%) ⬇️
aemcmc/utils.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@brandonwillard brandonwillard merged commit 50b7068 into aesara-devs:main Feb 16, 2023
@brandonwillard brandonwillard deleted the update-ci-setup branch February 16, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration important
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants