-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add F RandomVariable #1509
Add F RandomVariable #1509
Conversation
Much appreciated @aadya940! |
I guess the test's are failing due to an issue in sphinx. Can someone please review the code before we can merge it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are some formatting issues that should've been caught by pre-commit
.
I've fixed the formatting issues and squashed the commits. #1512 might need to go through before this will pass, though. |
Codecov Report
@@ Coverage Diff @@
## main #1509 +/- ##
=======================================
Coverage 74.96% 74.97%
=======================================
Files 176 176
Lines 49498 49507 +9
Branches 11986 11986
=======================================
+ Hits 37108 37117 +9
Misses 10089 10089
Partials 2301 2301
|
@aadya940, many thanks for the contribution! |
Welcome :-) |
Fixes #1366
Here are a few important guidelines and requirements to check before your PR can be merged:
pre-commit
is installed and set up.