Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add F RandomVariable #1509

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Add F RandomVariable #1509

merged 1 commit into from
Sep 21, 2023

Conversation

aadya940
Copy link
Contributor

@aadya940 aadya940 commented Sep 5, 2023

Fixes #1366

Here are a few important guidelines and requirements to check before your PR can be merged:

  • There is an informative high-level description of the changes.
  • The description and/or commit message(s) references the relevant GitHub issue(s).
  • pre-commit is installed and set up.
  • The commit messages follow these guidelines.
  • The commits correspond to relevant logical changes, and there are no commits that fix changes introduced by other commits in the same branch/BR.
  • There are tests covering the changes introduced in the PR.

@aadya940 aadya940 changed the title F op Add F RandomVariable Sep 5, 2023
@brandonwillard
Copy link
Member

Much appreciated @aadya940!

@aadya940
Copy link
Contributor Author

aadya940 commented Sep 8, 2023

I guess the test's are failing due to an issue in sphinx. Can someone please review the code before we can merge it?

Copy link
Member

@brandonwillard brandonwillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some formatting issues that should've been caught by pre-commit.

tests/tensor/random/test_basic.py Outdated Show resolved Hide resolved
@brandonwillard brandonwillard added enhancement New feature or request random variables Involves random variables and/or sampling labels Sep 9, 2023
@brandonwillard
Copy link
Member

brandonwillard commented Sep 20, 2023

I've fixed the formatting issues and squashed the commits. #1512 might need to go through before this will pass, though.

@brandonwillard brandonwillard merged commit ec4821e into aesara-devs:main Sep 21, 2023
20 of 21 checks passed
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #1509 (e7fc0db) into main (22e9d62) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1509   +/-   ##
=======================================
  Coverage   74.96%   74.97%           
=======================================
  Files         176      176           
  Lines       49498    49507    +9     
  Branches    11986    11986           
=======================================
+ Hits        37108    37117    +9     
  Misses      10089    10089           
  Partials     2301     2301           
Files Changed Coverage
aesara/tensor/random/basic.py 100.00%

@brandonwillard
Copy link
Member

@aadya940, many thanks for the contribution!

@aadya940
Copy link
Contributor Author

@aadya940, many thanks for the contribution!

Welcome :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request random variables Involves random variables and/or sampling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add f RandomVariable
2 participants