Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in TensorFromScalar #1519

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix memory leak in TensorFromScalar #1519

merged 1 commit into from
Oct 25, 2023

Conversation

brandonwillard
Copy link
Member

Closes #1517

@brandonwillard brandonwillard mentioned this pull request Oct 24, 2023
Closed
@brandonwillard brandonwillard added bug Something isn't working C-backend Op implementation Involves the implementation of an Op labels Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #1519 (5d9a965) into main (ec4821e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1519   +/-   ##
=======================================
  Coverage   74.97%   74.97%           
=======================================
  Files         176      176           
  Lines       49507    49507           
  Branches    11986    11986           
=======================================
  Hits        37117    37117           
  Misses      10089    10089           
  Partials     2301     2301
Files Coverage Δ
aesara/tensor/basic.py 89.99% <100.00%> (ø)

@brandonwillard
Copy link
Member Author

@mattearllongshot, if you can, give this branch a shot and tell me if your profiling results still look good. They should, but it's worth checking again.

@mattearllongshot
Copy link

Hello, I can confirm this fixes the leak for me. Thanks for the fix!

@brandonwillard brandonwillard merged commit 49ae74e into aesara-devs:main Oct 25, 2023
23 checks passed
@brandonwillard brandonwillard deleted the fix-TensorFromScalar-leak branch October 25, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working C-backend important Op implementation Involves the implementation of an Op
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory leak with a particular combination of operations
2 participants
@brandonwillard @mattearllongshot