Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover movies page #2

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Discover movies page #2

merged 3 commits into from
Nov 29, 2023

Conversation

aevans27
Copy link
Owner

@aevans27 aevans27 commented Nov 28, 2023

Description

Added discover movies page and dashboard. Setup Facades and Fixtures so app can run off line. Searches include top 20 and query for Batman. Setup webmock and added figoro gems. Added Poros and Service for Movie endpoints. Put in calls for show but haven't added view or tests for it yet. Setup faraday gem because it is required. Also updated the user table to include email, which will be used in later user stories.

Type of change

  • fix
  • feat
  • test
  • refactor
  • docs

Checklist

  • code has been self reviewed
  • code runs without any errors
  • thorough testing has been implemented if adding feature
  • all tests pass

Thanks!

@aevans27 aevans27 requested a review from bkchilidawg November 28, 2023 23:33
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice advanced routing!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mod 1 making a comeback!

@bkchilidawg bkchilidawg merged commit 9fa154f into main Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants