Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Movie Details Page #6

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Movie Details Page #6

merged 1 commit into from
Nov 29, 2023

Conversation

aevans27
Copy link
Owner

@aevans27 aevans27 commented Nov 29, 2023

Description

Added the movies details page also there is a viewing_parties/new page but it is empty for now. Hand rolled route I was having an issue setting it up. Adds view and tests using webmock to use 3 different api calls on the same page. Includes fixture files. Also added button into application.html.erb so it appears in each view.

Type of change

  • fix
  • feat
  • test
  • refactor
  • docs

Checklist

  • code has been self reviewed
  • code runs without any errors
  • thorough testing has been implemented if adding feature
  • all tests pass

Thanks!

… utility class for getting movie runtime in minutes, hand rolled route for it; may change later.
@aevans27 aevans27 requested a review from bkchilidawg November 29, 2023 18:40
@bkchilidawg bkchilidawg merged commit ebaa4ce into main Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants