Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/dashboard discover movies #8

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Conversation

bkchilidawg
Copy link
Collaborator

Description

add tests for dashboard discover movies and edit rubocop to ignore specs

Type of change

  • fix
  • feat
  • test
  • refactor
  • docs

Checklist

  • code has been self reviewed
  • code runs without any errors
  • thorough testing has been implemented if adding feature
  • all tests pass

Thanks!

Copy link
Owner

@aevans27 aevans27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for fixing rubocop too.

@aevans27
Copy link
Owner

Took care of the merge conflict, it should contain both of our tests.

@aevans27 aevans27 merged commit 0ae8e9d into main Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants