refactor(root_runner): move Strict under RunnerOptions

Strict was for some reason passed in the Runner struct unlike all the other options and flags.

internal/root_runner/log_branch_test.go

@@ -19,7 +19,6 @@ func TestLogBranch(t *testing.T) {
 	runner := Runner{
 		DebugLogger: log.New(ioutil.Discard, "", 0),
 		Logger:      &testLogger,
-		Strict:      false,
 		Debug:       false,
 	}
 

internal/root_runner/root_runner.go

@@ -9,7 +9,6 @@ import (
 type Runner struct {
 	DebugLogger *log.Logger
 	Logger      *log.Logger
-	Strict      bool
 	// Debug is a deprecated flag. Will be replaced as all repos accept the debugLogger
 	Debug bool
 }
@@ -23,10 +22,11 @@ type RunnerOptions struct {
 	Limit int
 	// AllCommits will check all the commits on the upstream branch. Regardless of Limit setting.
 	AllCommits bool
+	Strict     bool
 }
 
 // New returns a new instance of a RootRunner with fallback for logging
-func New(logger *log.Logger, debugLogger *log.Logger, strict bool) *Runner {
+func New(logger *log.Logger, debugLogger *log.Logger) *Runner {
 	if logger == nil {
 		logger = log.New(os.Stdout, "", 0)
 	}
@@ -37,6 +37,5 @@ func New(logger *log.Logger, debugLogger *log.Logger, strict bool) *Runner {
 	return &Runner{
 		Logger:      logger,
 		DebugLogger: debugLogger,
-		Strict:      strict,
 	}
 }

internal/root_runner/run.go

@@ -81,7 +81,7 @@ func (runner *Runner) Run(options RunnerOptions, args ...string) error {
 
 		parsedCommit := quoad.ParseCommitMessage(commitObject.Message)
 
-		textErr := text.CheckMessageTitle(parsedCommit, runner.Strict)
+		textErr := text.CheckMessageTitle(parsedCommit, options.Strict)
 
 		if textErr != nil {
 			faultyCommits = append(faultyCommits, text.FailingCommit{Hash: commitHash.String(), Message: parsedCommit.Heading, Error: textErr})

internal/root_runner/run_test.go

@@ -18,15 +18,16 @@ func TestCommitsOnMaster(t *testing.T) {
 	runner := Runner{
 		DebugLogger: log.New(ioutil.Discard, "", 0),
 		Logger:      &testLogger,
-		Strict:      false,
-		Debug:       false,
+
+		Debug: false,
 	}
 
 	options := RunnerOptions{
 		Path:           "../../testdata/commits-on-master",
 		UpstreamBranch: "master",
 		Limit:          0,
 		AllCommits:     false,
+		Strict:         false,
 	}
 
 	err := runner.Run(options)
@@ -44,15 +45,16 @@ func TestCommitsOnBranch(t *testing.T) {
 	runner := Runner{
 		DebugLogger: log.New(ioutil.Discard, "", 0),
 		Logger:      &testLogger,
-		Strict:      false,
-		Debug:       false,
+
+		Debug: false,
 	}
 
 	options := RunnerOptions{
 		Path:           "../../testdata/commits-on-different-branches",
 		UpstreamBranch: "master",
 		Limit:          0,
 		AllCommits:     false,
+		Strict:         false,
 	}
 
 	err := runner.Run(options, "master")
@@ -69,15 +71,16 @@ func TestFromToCommits(t *testing.T) {
 	runner := Runner{
 		DebugLogger: log.New(ioutil.Discard, "", 0),
 		Logger:      &testLogger,
-		Strict:      false,
-		Debug:       false,
+
+		Debug: false,
 	}
 
 	options := RunnerOptions{
 		Path:           "../../testdata/commits-on-different-branches",
 		UpstreamBranch: "master",
 		Limit:          0,
 		AllCommits:     false,
+		Strict:         false,
 	}
 
 	err := runner.Run(options, "7dbf3e7db93ae2e02902cae9d2f1de1b1e5c8c92...d0240d3ed34685d0a5329b185e120d3e8c205be4")

main.go

@@ -48,13 +48,14 @@ func runRoot(cmd *cobra.Command, args []string) error {
 
 	logger := log.New(os.Stdout, "", 0)
 
-	runner := root_runner.New(logger, &debugLogger, Strict)
+	runner := root_runner.New(logger, &debugLogger)
 
 	options := root_runner.RunnerOptions{
 		Path:           ".",
 		UpstreamBranch: upstreamBranch,
 		Limit:          0,
 		AllCommits:     AllCommits,
+		Strict:         Strict,
 	}
 
 	return runner.Run(options, args...)