Fix: forward config param from GitHub action propperly #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@beltrachi is attempting to deploy a commit to the Aevea Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fallion
approved these changes
Apr 3, 2024
if not, tests influece between each other as viper is already set.
verbose flag was loaded outside the configuration load, so whatever you did put in the config file was not applied later.
beltrachi
force-pushed
the
jb/fix-config-in-github-actions
branch
from
f01d52e
to
f98a638
Compare
|
Rebased the branch as it had conflicts with master. Also fixed typo "iterrates" in a comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The github action was not properly forwarding the config input to the docker container. It needs to use the
argsin therunssection.Changes:
--config-pathCLI parameter to the commitsar binary.PS: It's my first time I write go code, so any question/suggestion will be more than welcome.